Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix minor typo in comments #8736

Closed
wants to merge 1 commit into from
Closed

src: fix minor typo in comments #8736

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Sep 23, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

Correcting a couple of minor spelling typos in comments.

@danbev
src: fix minor typo in comments
de0fed7 
Correcting a couple of minor spelling typos in comments.
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Sep 23, 2016
lpinca
lpinca approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imyller
imyller approved these changes Sep 23, 2016
View reviewed changes
Copy link
Member

@imyller imyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

danbev added a commit to danbev/node that referenced this pull request Sep 24, 2016
@danbev
src: fix minor typo in comments
4f832eb 
Correcting a couple of minor spelling typos in comments.

PR-URL: nodejs#8736
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
@danbev
Copy link
Contributor Author

danbev commented Sep 24, 2016

Landed in 4f832eb

@danbev danbev closed this Sep 24, 2016
@danbev danbev deleted the fix-typo-in-node_contextify branch September 26, 2016 03:59
jasnell pushed a commit that referenced this pull request Sep 29, 2016
@danbev @jasnell
src: fix minor typo in comments
7b3a4c7 
Correcting a couple of minor spelling typos in comments.

PR-URL: #8736
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
geek pushed a commit to geek/node that referenced this pull request Sep 30, 2016
@danbev @geek
src: fix minor typo in comments
b8b90bb 
Correcting a couple of minor spelling typos in comments.

PR-URL: nodejs#8736
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@danbev @Fishrock123
src: fix minor typo in comments
8be818e 
Correcting a couple of minor spelling typos in comments.

PR-URL: #8736
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

@imyller imyller imyller approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @lpinca @imyller @targos @cjihrig @MylesBorins @nodejs-github-bot